Upload device keys to enable uploading OTKs#834
Merged
MadLittleMods merged 1 commit intomatrix-org:mainfrom Dec 19, 2025
Merged
Upload device keys to enable uploading OTKs#834MadLittleMods merged 1 commit intomatrix-org:mainfrom
MadLittleMods merged 1 commit intomatrix-org:mainfrom
Conversation
For servers that verify the OTKs are indeed signed by the device key.
MadLittleMods
approved these changes
Dec 19, 2025
Comment on lines
+183
to
+187
| deviceKeys, oneTimeKeys := alice.MustGenerateOneTimeKeys(t, 2) | ||
|
|
||
| // first upload key 1, sleep a bit, then upload key 0. | ||
| otk1 := map[string]interface{}{"signed_curve25519:1": oneTimeKeys["signed_curve25519:1"]} | ||
| alice.MustUploadKeys(t, nil, otk1) | ||
| alice.MustUploadKeys(t, deviceKeys, otk1) |
Collaborator
There was a problem hiding this comment.
This is the only place where we didn't do this. Are we sure this wasn't on purpose (should have had a comment if-so)?
This test is about one-time key claim ordering so it shouldn't matter ⏩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For servers that verify the OTKs are indeed signed by the device key.
Pull Request Checklist
Signed-off-by: Nick @ Beeper (@Fizzadar) <nick@beeper.com)